Submission Details
Impact:
Likelihood:
Redundant `require(_price > 0)` in `NFTDealers::list()` wastes gas
Author Revealed upon completion
Redundant `require(_price > 0)` in `NFTDealers::list()` wastes gas
Description
`NFTDealers::list()` contains two price validation checks where the second is completely redundant. Since `MIN_PRICE = 1e6`, any price passing the first check is guaranteed to be greater than zero.
require(_price >= MIN_PRICE, "Price must be at least 1 USDC"); // MIN_PRICE = 1e6
// ...
require(_price > 0, "Price must be greater than 0"); // @> never reachable
Risk
-
Proof of Concept
-
Recommended Mitigation
Remove the redundant check:
-require(_price > 0, "Price must be greater than 0");
Rewards breakdown
nSLOC
253This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.
Rewards Distribution
The contest is complete and the rewards are being distributed.