Submission Details
Impact:
Likelihood:
`NFT_Dealers_Sold` event missing `listingId` and `tokenId` making off-chain tracking unreliable
Author Revealed upon completion
`NFT_Dealers_Sold` event missing `listingId` and `tokenId` making off-chain tracking unreliable
Description
The `NFT_Dealers_Sold` event only emits `soldTo` and `price`, omitting both `listingId` and `tokenId`. This makes it impossible for off-chain indexers or subgraphs to reliably reconstruct the full lifecycle of a listing solely from events.
// Missing listingId and tokenId
event NFT_Dealers_Sold(address indexed soldTo, uint256 price); // @>
// Compare with other events that include listingId:
event NFT_Dealers_Listed(address indexed listedBy, uint256 listingId);
event NFT_Dealers_ListingCanceled(uint256 listingId);
Risk
This approach will make off chain tracking unreliable because in Sold event there is no listingId indexed
Proof of Concept
-
Recommended Mitigation
Add the listingId for make off chian tracking much easier
- event NFT_Dealers_Sold(address indexed soldTo, uint256 price);
+ event NFT_Dealers_Sold(address indexed soldTo, uint256 indexed listingId, uint256 price);
Rewards breakdown
nSLOC
253This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.
Rewards Distribution
The contest is complete and the rewards are being distributed.