Submission Details
Severity:
allow zero value to be transferred waste gas
Vulnerability Details
if the price has value of zero then when the buyer call confirmReceipt() function this will result in transferring zero value to the seller
function confirmReceipt() external onlyBuyer inState(State.Created) {
s_state = State.Confirmed;
emit Confirmed(i_seller);
i_tokenContract.safeTransfer(i_seller, i_tokenContract.balanceOf(address(this)));
}
Impact
gas optimization
Tools Used
manual review
Recommendations
add a check for the value that is going to be sent .
if (address(this).balance > 0) {
i_tokenContract.safeTransfer(i_seller, i_tokenContract.balanceOf(address(this)));
}
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215 USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.