CodeHawks Escrow Contract - Competition Details

Summary

The docs clearly state that ERC777 should be discouraged due to the risk of DOS attacks. The 'resolveDispute' function follows the checks effects interaction pattern and so reentrancy is currently not possible.

"Tokens with callbacks allow malicious sellers to DOS dispute resolutions - Each supported token will be vetted to be supported. ERC777 should be discouraged."

Vulnerability Details

Consider removing the nonReentrant and non-importing the reentrancy guard contracts as it is a waste of gas and does not use a consistent pattern across the contracts.

Tools Used

Manual review.

Recommendations

Consider removing the Reentrancy Guard import as it is not necessary.