Submission Details
Severity:
Events are missing sender information
Summary
Events are missing sender information
Vulnerability Details
When an action is triggered based on a user's action, not being able to filter based on who triggered the action makes event processing a lot more cumbersome.
Including the msg.sender the events of these types of action will make events much more useful to end users, especially when msg.sender is not tx.origin.
Instances (2):
File: src/Escrow.sol
96: emit Confirmed(i_seller);
121: emit Resolved(i_buyer, i_seller);
Link to code - https://github.com/Cyfrin/2023-07-escrow/tree/main/src/Escrow.sol
Tools Used
Manual Code Review
Recommendations
Use msg.sender in the events
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215 USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.