Submission Details
Severity:
Constants in comparisons should appear on the left side
Summary
Constants in comparisons should appear on the left side
Vulnerability Details
Doing so will prevent typo bugs
Instances (6):
File: src/Escrow.sol
41: if (buyer == address(0)) revert Escrow__BuyerZeroAddress();
42: if (seller == address(0)) revert Escrow__SellerZeroAddress();
106: if (i_arbiter == address(0)) revert Escrow__DisputeRequiresArbiter();
128: if (buyerAward > 0) {
131: if (i_arbiterFee > 0) {
135: if (tokenBalance > 0) {
Link to code - https://github.com/Cyfrin/2023-07-escrow/tree/main/src/Escrow.sol
Tools Used
Manual Code Review
Recommendations
Use constants on the left side
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215 USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.