DittoETH

Summary

Vulnerability Details

The lack of a zero address validation in this context could potentially lead to unexpected results. For example, if a zero address is used as an input in a function that uses this modifier, the function might consider it as a valid asset, given its frozen status is F.Permanent. Although this situation is unlikely, it is theoretically possible.

Impact

Tools Used

Manual

Recommendations

Here is a recommended fix:

'''
modifier isPermanentlyFrozen(address asset) {
require(asset != address(0), "Asset address cannot be 0");
if (s.asset[asset].frozen != F.Permanent) {
revert Errors.AssetIsNotPermanentlyFrozen();
}
_;
}