DittoETH

Summary

Missing zero check address of modifier onlyValidShortRecord

Vulnerability Details

The 'onlyValidShortRecord' modifier validates if the given 'id' is within the range of 'maxId' and 'Constants.SHORT_STARTING_ID', and verifies whether the short record with the corresponding 'id' has been cancelled. However, it lacks a null check for the 'id'. This omission could potentially cause problems if a null 'id' is input into the function utilizing this modifier. Therefore, I recommend incorporating a null check for the 'id' to guarantee consistent function performance under all circumstances.

Impact

Tools Used

Recommendations