DittoETH

Ditto
DeFiFoundryOracle
55,000 USDC
View results
Submission Details
Severity: medium
Invalid

Missing zero address check in VaultFacet

Vulnerability Details

In VaultFacet.sol:27, the constructor initializes the carbonZeth immutable variable with the _zeth address provided as a parameter. However, there is no check to ensure that the _zeth address is not the zero address.

constructor(address _zeth) {
carbonZeth = _zeth;
}

Impact

By failing to check if _zeth is the zero address, there is a potential risk of funds being accidentally. This can lead to permanent loss of funds as the zero address is non-recoverable.

Tools Used

Manual Review

Recommendations

Before assigning the value of _zeth to carbonZeth, implement a check to ensure that _zeth is not the zero address.

Updates

Lead Judging Commences

0xnevi Lead Judge
almost 2 years ago
0xnevi Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Zero address checks

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.