DittoETH

Ditto
DeFiFoundryOracle
55,000 USDC
View results
Submission Details
Severity: medium
Invalid

Missing zero address check in YieldFacet

Vulnerability Details

  • Identifier: M-08

  • Description: No checks for _ditto not being the zero address.

Code Snippet:

In YieldFacet.sol:31,

IAsset private immutable DITTO;
constructor(address _ditto) {
DITTO = IAsset(_ditto);
}

Impact

If the _ditto address provided to the constructor is the zero address, the smart contract would set its DITTO state variable to this invalid address. Any interactions or operations using this address can lead to unexpected behavior.

Tools Used

Manual Review

Recommendations

Add a validation check in the constructor to ensure that the _ditto address is not the zero address.

Updates

Lead Judging Commences

0xnevi Lead Judge
almost 2 years ago
0xnevi Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Zero address checks

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.