DittoETH

Summary

Twap time is hardcoded to 30 minutes so instead of hardcoding take the time interval as perimeter.

Vulnerability Details

In the function baseOracleCircuitBreaker() twap time is hardcoded to 30 minutes which is not optimal in all cases cause even tho the twap is resilient to flashLoan but still it can be manipulated, there are websites that will tell you how much it takes to manipulate the twap price.

This is the effected line,

Impact

Let user input the twap price instead of hardcoding as 30 minute timeframe is not optimal and ideal

Tools Used

Manual Review

Recommendations

It is recommended that instead of harcoding take the twap timeframe as input.