DittoETH

Ditto
DeFiFoundryOracle
55,000 USDC
View results
Submission Details
Severity: medium
Invalid

Hardcoded min delay in constructor

Summary

Hardcoding the min delay could have unintended consequences in the contract.

Vulnerability Details

In the DittoTimelockController.sol contract we have this line

TimelockController(0, proposers, executors, admin)

but if we see the Natspec above this line which are

// arg[1] - propser - set to deployer
// arg[2] - executor - set to deployer
// arg[3] - admin - remember to revoke

we can see that arg[0] is the min delay which is 2 days, but in the above line we can see that minimum delay is set to 0 which could have unintended consequences.

Impact

Hardcoding 0 could have unintended consequences

Tools Used

Manual Review

Recommendations

do not hardcode 0 instead take it as perimeter

Updates

Lead Judging Commences

0xnevi Lead Judge
almost 2 years ago
0xnevi Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Other

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.