Missing zero address validation in constructor
Missing zero address validation in constructor
Severity: Low
Confidence: Medium
Description
Detect missing zero address validation in the constructor.
There are 14 instances of this issue:
state variable rocketStorage assign with rocketStorageAddress without checking
https://github.com/Cyfrin/2023-09-ditto/blob/main/contracts/bridges/BridgeReth.sol#L21
state variable diamond assign with diamondAddr without checking
https://github.com/Cyfrin/2023-09-ditto/blob/main/contracts/bridges/BridgeReth.sol#L22
state variable steth assign with _steth without checking
https://github.com/Cyfrin/2023-09-ditto/blob/main/contracts/bridges/BridgeSteth.sol#L22
state variable unsteth assign with _unsteth without checking
https://github.com/Cyfrin/2023-09-ditto/blob/main/contracts/bridges/BridgeSteth.sol#L23
state variable diamond assign with diamondAddr without checking
https://github.com/Cyfrin/2023-09-ditto/blob/main/contracts/bridges/BridgeSteth.sol#L24
state variable rethBridge assign with _rethBridge without checking
https://github.com/Cyfrin/2023-09-ditto/blob/main/contracts/facets/BridgeRouterFacet.sol#L28
state variable stethBridge assign with _stethBridge without checking
https://github.com/Cyfrin/2023-09-ditto/blob/main/contracts/facets/BridgeRouterFacet.sol#L29
state variable cusd assign with _cusd without checking
https://github.com/Cyfrin/2023-09-ditto/blob/main/contracts/facets/ExitShortFacet.sol#L30
state variable cusd assign with _cusd without checking
https://github.com/Cyfrin/2023-09-ditto/blob/main/contracts/facets/MarginCallPrimaryFacet.sol#L30
state variable cusd assign with _cusd without checking
https://github.com/Cyfrin/2023-09-ditto/blob/main/contracts/facets/ShortRecordFacet.sol#L26
state variable carbonZeth assign with _zeth without checking
https://github.com/Cyfrin/2023-09-ditto/blob/main/contracts/facets/VaultFacet.sol#L27
state variable DITTO assign with _ditto without checking
https://github.com/Cyfrin/2023-09-ditto/blob/main/contracts/facets/YieldFacet.sol#L31
state variable diamond assign with diamondAddr without checking
https://github.com/Cyfrin/2023-09-ditto/blob/main/contracts/tokens/Asset.sol#L14
state variable diamond assign with diamondAddr without checking
https://github.com/Cyfrin/2023-09-ditto/blob/main/contracts/tokens/Ditto.sol#L16
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.