Submission Details
Severity:
External calls in an un-bounded for-loop may result in a DOS
External calls in an un-bounded for-loop may result in a DOS
Severity: Low
Confidence: Medium
Description
Calls inside a loop might lead to a denial-of-service attack.
There are 4 instances of this issue:
File: contracts/facets/ERC721Facet.sol
22 function balanceOf(address owner) external view returns (uint256 balance)
has external calls inside a loop:
File: contracts/facets/ERC721Facet.sol
29 STypes.ShortRecord[] memory shortRecords =
30 IDiamond(payable(address(this))).getShortRecords(s.assets[i], owner)
https://github.com/Cyfrin/2023-09-ditto/blob/main/contracts/facets/ERC721Facet.sol#L22-L43
File: contracts/facets/MarginCallSecondaryFacet.sol
38 function liquidateSecondary(
39 address asset,
40 MTypes.BatchMC[] memory batches,
41 uint88 liquidateAmount,
42 bool isWallet
43 ) external onlyValidAsset(asset) isNotFrozen(asset) nonReentrant
has external calls inside a loop:
File: contracts/facets/MarginCallSecondaryFacet.sol
84 uint256 walletBalance = tokenContract.balanceOf(msg.sender)
File: contracts/facets/MarginCallSecondaryFacet.sol
38 function liquidateSecondary(
39 address asset,
40 MTypes.BatchMC[] memory batches,
41 uint88 liquidateAmount,
42 bool isWallet
43 ) external onlyValidAsset(asset) isNotFrozen(asset) nonReentrant
has external calls inside a loop:
File: contracts/facets/MarginCallSecondaryFacet.sol
86 tokenContract.burnFrom(msg.sender, m.short.ercDebt)
File: contracts/facets/MarginCallSecondaryFacet.sol
38 function liquidateSecondary(
39 address asset,
40 MTypes.BatchMC[] memory batches,
41 uint88 liquidateAmount,
42 bool isWallet
43 ) external onlyValidAsset(asset) isNotFrozen(asset) nonReentrant
has external calls inside a loop:
File: contracts/facets/MarginCallSecondaryFacet.sol
87 assert(tokenContract.balanceOf(msg.sender) < walletBalance)
Prize pool breakdown
Total prize
55,000 USDC
nSLOC
3,36516 USDC / LOC
50,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.