Submission Details
Severity:
Front Running on Exit Short
Summary
exitShort() is vulnerable to front running.
Vulnerability Details
exitShort() creates a forced bid using msg.sender as the bidder. It does not check that msg.sender matches the short owner.
This allows an attacker to front run the transaction and place the bid themselves.
Impact
Attacker could steal funds by filling their own forced bid order.
Tools Used
Manual
Recommendations
Add a onlyShortOwner modifier:
modifier onlyShortOwner(address owner, uint8 id) {
require(shortRecords[asset][owner][id].addr == msg.sender, "Not short owner");
_;
}
function exitShort(
// ...
) external onlyShortOwner(msg.sender, id) {
// ...
}
Prize pool breakdown
Total prize
55,000 USDC
nSLOC
3,36516 USDC / LOC
50,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.