DittoETH

Ditto
DeFiFoundryOracle
55,000 USDC
View results
Submission Details
Severity: medium
Invalid

Potential Reentrancy in Exit Short

Summary

Exiting shorts via exitShort can be vulnerable to reentrancy.

Vulnerability Details

exitShort calls external contracts to burn debt. If these are malicious, they could reenter before state is updated.

For example:

function exitShort(
// ...
) external {
asset.burnMsgSenderDebt(amount);
// Vulnerable to reentry
short.ercDebt -= amount;
}

Impact

Reentrancy could prevent debt burn or cause unexpected side effects.

Tools Used

Manual

Recommendations

  • Use checks-effects-interactions pattern

  • Add reentrancy guard

Updates

Lead Judging Commences

0xnevi Lead Judge
almost 2 years ago
0xnevi Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Other

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.