Submission Details
Severity:
LiquidationPoolManager::distributeFees can truncate decimal resolution due to division before multiply
Summary
LiquidationPoolManager::distributeFees() function does not priorities multiplication operation over division leading to loss of decimal resolution.
The fee for pool calculation can loose decimal resolution.
Vulnerability Details
In the below like, the division can happen before multiplication leading in loss of precision.
uint256 _feesForPool = eurosToken.balanceOf(address(this)) * poolFeePercentage / HUNDRED_PC;
Impact
feesForPool can be lower because of this lack in order of mathematics operation
Tools Used
Manual
Recommendations
Assign order of execution by add braces
uint256 _feesForPool = (eurosToken.balanceOf(address(this)) * poolFeePercentage) / HUNDRED_PC;
Updates
Lead Judging Commences
hrishibhat over 1 year ago
Submission Judgement Published Assigned finding tags:
precision-distributeFees
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933 USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.