Submission Details
Severity:
LiquidationPoolManager::distributeFees's does not handle return value for transfer call
Summary
The transfer call on Eurotoken to protocol address can fail. The distributeFees() function does not handle the failure case.
Vulnerability Details
The below call to transfer could fail and that scenario is not handled.
eurosToken.transfer(protocol, eurosToken.balanceOf(address(this)));
Impact
It will result in incorrect amount of fee per pool and also the amount approved and distributed by LiquidationPool.
Tools Used
Manual review
Recommendations
Using safe transfer wrapper functions from Openzepplien
Updates
Lead Judging Commences
hrishibhat over 1 year ago
Submission Judgement Published Reason: Known issue
Assigned finding tags:
informational/invalid
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933 USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.