Submission Details
Severity:
`Magic Number` insights. May mislead or stuck users.
Summary
There are a few magic numbers that should be replaced with constants.
Airdrop::claim
...
...
...
// ----------------------------------------------------
// -------------------------- ||
// ------------- \/
@> if (amountAlreadyClaimed >= numberOfDaysInCouple * 10 ** loveToken.decimals()) {
revert Airdrop__PreviousTokenAlreadyClaimed();
}
// ------------------------------------------------------------
// ------------------------------ ||
// --------------- \/
@> uint256 tokenAmountToDistribute = (numberOfDaysInCouple * 10 ** loveToken.decimals()) - amountAlreadyClaimed;
...
...
...
Soulmate::totalSouls
...
...
...
function totalSouls() external view returns (uint256) {
// ----------------------
// ----------- ||
// ----- \/
@> return nextID * 2;
}
...
...
...
LoveToken::initVault
function initVault(address managerContract) public {
if (msg.sender == airdropVault) {
// ----------------------------------
// ----------------- ||
// -------- \/
@> _mint(airdropVault, 500_000_000 ether);
// ---------------------------------------
// -------------------- ||
// --------- \/
@> approve(managerContract, 500_000_000 ether);
emit AirdropInitialized(managerContract);
} else if (msg.sender == stakingVault) {
// ----------------------------------
// ----------------- ||
// -------- \/
@> _mint(stakingVault, 500_000_000 ether);
// ---------------------------------------
// -------------------- ||
// --------- \/
@> approve(managerContract, 500_000_000 ether);
emit StakingInitialized(managerContract);
} else {
revert LoveToken__Unauthorized();
}
}
Impact
Could be confusing to the community developers who evolved with this convention but not mentioned by solidity docs.
Tools Used
Manual Review
Recommendations
Make constants for each of Magic Numbers.
Rewards breakdown
nSLOC
233This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.