First Flight #9: Soulmate

Summary

• functions currently have public visibility specifier, should have external visibility specifier.

  1. Staking::Deposit

  2. Staking::withdraw

  3. Staking::claimRewards

  4. Vault::initVault

  5. LoveToken::initVault

  6. Airdrop::claim

  7. Soulmate::mintSoulmateToken

  8. Soulmate::getDivorced

Impact

1. No direct impact, But can influence the GAS Cost to high indirectly.

2. Public functions first copies parameters into memory.

3. External functions parameters are directly read from calldata, hence it costs less than public.

Tools Used

Manual Review

Recommendations

Mitigation is simple, Use external visibility specifier keyword instead of public at all functions metioned above.