Submission Details
Severity:
Variable `Aidrop::daysInSecond` variable is not needed.
Summary
The variable daysInSecond is not needed and can be replaced with a built in variable in solidity days. This would prevent any sort of typos or mistakes.
Vulnerability Details
In the example below we can see the two values are equal.
function test_secondsInDays() external {
console.log(1 days);
console.log(airdropContract.daysInSecond());
assertEq(1 days, airdropContract.daysInSecond());
}
}
Impact Would help reduce potential mistakes and typos.
Tools Used
Foundry
Recommendations
- uint256 public constant daysInSecond = 3600 * 24;
....
- uint256 numberOfDaysInCouple = (block.timestamp - soulmateContract.idToCreationTimestamp(soulmateContract.ownerToId(msg.sender))) / daysInSecond;
+ uint256 numberOfDaysInCouple = (block.timestamp - soulmateContract.idToCreationTimestamp(soulmateContract.ownerToId(msg.sender))) / 1 days;
Rewards breakdown
nSLOC
233This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.