Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

Magic Numbers in `LoveToken.sol::initVault` should be converted to constants.

Summary Numbers found in initVault should be converted to constants to avoid any sort of confusion.

Vulnerability Details "Magic Numbers" such as those used in initVault should be converted to public constants instead of using inline values.

Tools Used

Foundry

Recommendations

uint256 public constant initalSupplyValue = 500_000_000 ether;
function initVault(address managerContract) public {
if (msg.sender == airdropVault) {
- _mint(airdropVault, 500_000_000 ether);
+ _mint(airdropVault, initalSupplyValue);
- approve(managerContract, 500_000_000 ether);
+ approve(managerContract, initalSupplyValue );
emit AirdropInitialized(managerContract);
} else if (msg.sender == stakingVault) {
- _mint(stakingVault, 500_000_000 ether);
+ _mint(stakingVault, initalSupplyValue);
- approve(managerContract, 500_000_000 ether);
+ approve(managerContract, initalSupplyValue);
emit StakingInitialized(managerContract);
} else revert LoveToken__Unauthorized();
}
Updates

Lead Judging Commences

0xnevi Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.