First Flight #9: Soulmate

Summary

This mapping is not updated, especially in ‘getDivorced()’, this
can potentially cause a big issue in the protocol. ## Vulnerability Details

Impact

Others contract can’t actually see if msg.sender has actually a
soulmate or not if this value is not updated, also, after user calls the function
‘getDivorced’ he will never have more the possibility to have a new soulmate
because ‘soulmateOf’ has not been updated.

Tools Used

Foundry

Recommendations

Update this mapping every time is needed, so
for example also in ‘getDivorced’