Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: medium
Valid

People can have themself as soulmates and mint multiples tokens

Summary

Vulnerability Details

In the function ‘mintSoulmateToken’, people have the possibility
to mint a large amount of tokens because they can have themself as
soulmates, and so they can create multiples accounts and mint a lot of
tokens.

Impact

Users (no need to be hacker) can mint more tokens.

Tools Used

Foundry

Recommendations

It is recommended to require that soulmates can’t
be the same address.

Updates

Lead Judging Commences

0xnevi Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-self-soulmate

- Given the native anonymous nature of blockchain in general, this issue cannot be avoided unless an explicit whitelist is implemented. Even then we can only confirm soulmates are distinct individuals via kyc. I believe finding a soulmate is intended to be permisionless. - However, even though sufficient (500_000_000e18 in each vault) tokens are minted to claim staking and airdrop rewards, it would take 500_000_000 / 2 combined weeks for airdrop vault to be drained which is not unreasonable given there are [80+ million existing wallets](https://coinweb.com/trends/how-many-crypto-wallets-are-there/). Given there is no option to mint new love tokens, this would actually ruin the functionality of the protocol of finding soulmates and shift the focus to abusing a sybil attack to farming airdrops instead. Assigning medium severity for now but am open for appeals otherwise, since most if not all issues lack indepth analysis of the issue.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.