Wrong event is emitted when soulmates are reunited
Description: The event emitted when the second soulmate calls the function Soulmate.sol::mintSoulmateToken() is emitting the wrong address in the second parameter. It is emitting the null address instead of the second soulmate's address:
Impact: This can mess the monitoring systems tracking the activity of the contract, assigning the null address always as the second soulmate.
Recommended Mitigation: Update the second parameter to:
Lead Judging Commences
finding-mintSoulmateToken-wrong-emit-soulmate2
Low severity, inconsistencies in event emission Sidenote: Separating all event findings given root causes are different with different functions involved. There could be alot of debate on whether wrong emit events consitute low severity, but I believe, - There are direct inconsistencies in the code logic - Codehawks [low severity categorization guidelines](https://docs.codehawks.com/hawks-auditors/how-to-evaluate-a-finding-severity#low-severity-findings) supports its severity as seen below, especially noting the term `Minimal to no impact` > - Minimal to no impact on the funds or the protocol's main functionality.
Rewards breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.