Tadle

Summary

Several contracts contain unused imports.

Commit Hash: 04fd8634701697184a3f3a5558b41c109866e5f8

Repository URL: https://github.com/Cyfrin/2024-08-tadle/tree/main

Impact

Importing files that are not used in a contract likely indicates a mistake. The imports should be removed until they are needed.

Occurences: 4

• PreMarkets.sol - https://github.com/Cyfrin/2024-08-tadle/blob/main/src/core/PreMarkets.sol

  import {IWrappedNativeToken} from "../interfaces/IWrappedNativeToken.sol";

• PerMarketsStorage.sol - https://github.com/Cyfrin/2024-08-tadle/blob/main/src/storage/PerMarketsStorage.sol

  import {OfferStatus} from "./OfferStatus.sol";

• TadleFactory.sol - https://github.com/Cyfrin/2024-08-tadle/blob/main/src/factory/TadleFactory.sol

  import {ProxyAdmin} from "@openzeppelin/contracts/proxy/transparent/ProxyAdmin.sol";

• UpgradeableProxy.sol - https://github.com/Cyfrin/2024-08-tadle/blob/main/src/proxy/UpgradeableProxy.sol

  import {Errors} from "../utils/Errors.sol";

Tools Used

• Manual Code Review: Analyzing the contract code directly

• Static Analysis Tools: Slither - https://github.com/crytic/slither

Recommendations

1. Unused imports ought to be removed